From 00d17a89fb9a696033eaaa6ce038d1c6a7eba394 Mon Sep 17 00:00:00 2001 From: jmjoy Date: Thu, 19 Mar 2026 09:23:10 +0800 Subject: [PATCH 1/3] feat: Enhance CI configuration with debug options for PHP versions --- .github/workflows/ci.yml | 40 +++++++++++++++++++++------------------- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f16e7f0..c2f1ff3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -42,26 +42,27 @@ jobs: matrix: include: # Ubuntu - all PHP versions - - { os: ubuntu-24.04, php-version: "7.0", ts: false } - - { os: ubuntu-24.04, php-version: "7.1", ts: false } - - { os: ubuntu-24.04, php-version: "7.2", ts: false } - - { os: ubuntu-24.04, php-version: "7.3", ts: false } - - { os: ubuntu-24.04, php-version: "7.4", ts: false } - - { os: ubuntu-24.04, php-version: "8.0", ts: false } - - { os: ubuntu-24.04, php-version: "8.1", ts: false } - - { os: ubuntu-24.04, php-version: "8.2", ts: false } - - { os: ubuntu-24.04, php-version: "8.3", ts: false } - - { os: ubuntu-24.04, php-version: "8.4", ts: false } - - { os: ubuntu-24.04, php-version: "8.5", ts: false } + - { os: ubuntu-24.04, php-version: "7.0", ts: false, debug: false } + - { os: ubuntu-24.04, php-version: "7.1", ts: false, debug: false } + - { os: ubuntu-24.04, php-version: "7.2", ts: false, debug: false } + - { os: ubuntu-24.04, php-version: "7.3", ts: false, debug: false } + - { os: ubuntu-24.04, php-version: "7.4", ts: false, debug: false } + - { os: ubuntu-24.04, php-version: "8.0", ts: false, debug: false } + - { os: ubuntu-24.04, php-version: "8.1", ts: false, debug: false } + - { os: ubuntu-24.04, php-version: "8.2", ts: false, debug: false } + - { os: ubuntu-24.04, php-version: "8.3", ts: false, debug: false } + - { os: ubuntu-24.04, php-version: "8.4", ts: false, debug: false } + - { os: ubuntu-24.04, php-version: "8.5", ts: false, debug: false } # Ubuntu - ZTS smoke matrix - - { os: ubuntu-24.04, php-version: "8.1", ts: true } - - { os: ubuntu-24.04, php-version: "8.2", ts: true } + - { os: ubuntu-24.04, php-version: "8.5", ts: true, debug: false } + # Ubuntu - debug smoke matrix + - { os: ubuntu-24.04, php-version: "8.5", ts: false, debug: true } # macOS - PHP 8.1+ - - { os: macos-14, php-version: "8.1", ts: false } - - { os: macos-14, php-version: "8.2", ts: false } - - { os: macos-14, php-version: "8.3", ts: false } - - { os: macos-14, php-version: "8.4", ts: false } - - { os: macos-14, php-version: "8.5", ts: false } + - { os: macos-14, php-version: "8.1", ts: false, debug: false } + - { os: macos-14, php-version: "8.2", ts: false, debug: false } + - { os: macos-14, php-version: "8.3", ts: false, debug: false } + - { os: macos-14, php-version: "8.4", ts: false, debug: false } + - { os: macos-14, php-version: "8.5", ts: false, debug: false } runs-on: ${{ matrix.os }} steps: @@ -79,6 +80,7 @@ jobs: tools: php-config env: phpts: ${{ matrix.ts == true && 'ts' || 'nts' }} + debug: ${{ matrix.debug == true && 'true' || 'false' }} - name: PHP version run: | @@ -108,7 +110,7 @@ jobs: ~/.cargo/registry/cache/ ~/.cargo/git/db/ target/ - key: ${{ matrix.os }}-ci-${{ matrix.php-version }}-ts-${{ matrix.ts }}-${{ hashFiles('**/Cargo.lock') }} + key: ${{ toJSON(matrix) }}-${{ hashFiles('**/Cargo.lock') }} - name: Cargo fmt uses: actions-rs/cargo@v1 From 426f4ec915575e4196d5b314f11170cd16052110 Mon Sep 17 00:00:00 2001 From: jmjoy Date: Thu, 19 Mar 2026 09:26:40 +0800 Subject: [PATCH 2/3] feat: Update CI cache key format to include PHP version and debug options --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c2f1ff3..e6727e3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -110,7 +110,7 @@ jobs: ~/.cargo/registry/cache/ ~/.cargo/git/db/ target/ - key: ${{ toJSON(matrix) }}-${{ hashFiles('**/Cargo.lock') }} + key: ${{ matrix.os }}-ci-${{ matrix.php-version }}-ts-${{ matrix.ts }}-debug-${{ matrix.debug }}-${{ hashFiles('**/Cargo.lock') }} - name: Cargo fmt uses: actions-rs/cargo@v1 From 80c22aef8bd746b099b142416102878d614d91d7 Mon Sep 17 00:00:00 2001 From: jmjoy Date: Thu, 19 Mar 2026 10:13:16 +0800 Subject: [PATCH 3/3] fix: update README to reflect correct status for PHP debug mode --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 14d313c..385c61d 100644 --- a/README.md +++ b/README.md @@ -44,7 +44,7 @@ The framework that allows us to write PHP extensions using pure and safe Rust wh | **SAPI** | CLI | ✅ | | | FPM | ✅ | | **Debug** | Disable | ✅ | -| | Enable | ❌ | +| | Enable | ✅ | ## Examples