From 112d0480cffa21c4d3efd102f600c3e72f51e8a3 Mon Sep 17 00:00:00 2001
From: jlothe <jyotsna.lothe@hpe.com>
Date: Mon, 9 Feb 2026 13:47:08 +0530
Subject: [PATCH 1/2] ESI-3304 - Added changes to handle deprecated QOS params
 From AllertaMP 10.5.0 onwards

---
 cinder/volume/drivers/hpe/hpe_3par_common.py | 86 +++++++++++++-------
 1 file changed, 56 insertions(+), 30 deletions(-)

diff --git a/cinder/volume/drivers/hpe/hpe_3par_common.py b/cinder/volume/drivers/hpe/hpe_3par_common.py
index 8591d3434e..58245a6af7 100644
--- a/cinder/volume/drivers/hpe/hpe_3par_common.py
+++ b/cinder/volume/drivers/hpe/hpe_3par_common.py
@@ -2021,6 +2021,15 @@ def _get_qos_value(self, qos, key, default=None):
         else:
             return default
 
+    def _is_alletra_mp(self):
+        """Check if the backend is AlletraMP based on WSAPI version.
+        
+        AlletraMP uses WSAPI version >= 100500000 (API_VERSION_2025).
+        
+        :returns: True if AlletraMP, False otherwise
+        """
+        return self.API_VERSION >= API_VERSION_2025
+
     def _get_qos_by_volume_type(self, volume_type):
         qos = {}
         qos_specs_id = volume_type.get('qos_specs_id')
@@ -2061,38 +2070,55 @@ def _set_qos_rule(self, qos, vvs_name):
         max_bw = self._get_qos_value(qos, 'maxBWS')
         latency = self._get_qos_value(qos, 'latency')
         priority = self._get_qos_value(qos, 'priority', 'normal')
+        
+        # Check if backend is AlletraMP
+        is_alletra_mp = self._is_alletra_mp()
 
         qosRule = {}
-        if min_io:
-            qosRule['ioMinGoal'] = int(min_io)
-            if max_io is None:
-                qosRule['ioMaxLimit'] = int(min_io)
-        if max_io:
-            qosRule['ioMaxLimit'] = int(max_io)
-            if min_io is None:
-                qosRule['ioMinGoal'] = int(max_io)
-        if min_bw:
-            qosRule['bwMinGoalKB'] = int(min_bw) * units.Ki
-            if max_bw is None:
-                qosRule['bwMaxLimitKB'] = int(min_bw) * units.Ki
-        if max_bw:
-            qosRule['bwMaxLimitKB'] = int(max_bw) * units.Ki
-            if min_bw is None:
-                qosRule['bwMinGoalKB'] = int(max_bw) * units.Ki
-        if latency:
-            # latency could be values like 2, 5, etc or
-            # small values like 0.1, 0.02, etc.
-            # we are converting to float so that 0.1 doesn't become 0
-            latency = float(latency)
-            if latency >= 1:
-                # by default, latency in millisecs
-                qosRule['latencyGoal'] = int(latency)
-            else:
-                # latency < 1 Eg. 0.1, 0.02, etc
-                # convert latency to microsecs
-                qosRule['latencyGoaluSecs'] = int(latency * 1000)
-        if priority:
-            qosRule['priority'] = self.qos_priority_level.get(priority.lower())
+        
+        # For AlletraMP, ioMinGoal, bwMinGoalKB, latencyGoal, and priority
+        # are deprecated. Only use max limits.
+        if is_alletra_mp:
+            # AlletraMP: Only set max limits, min goals are deprecated
+            if max_io:
+                qosRule['ioMaxLimit'] = int(max_io)
+            
+            if max_bw:
+                qosRule['bwMaxLimitKB'] = int(max_bw) * units.Ki
+
+
+        else:
+            # 3PAR/Primera/Alletra 9k: Use traditional QoS parameters
+            if min_io:
+                qosRule['ioMinGoal'] = int(min_io)
+                if max_io is None:
+                    qosRule['ioMaxLimit'] = int(min_io)
+            if max_io:
+                qosRule['ioMaxLimit'] = int(max_io)
+                if min_io is None:
+                    qosRule['ioMinGoal'] = int(max_io)
+            if min_bw:
+                qosRule['bwMinGoalKB'] = int(min_bw) * units.Ki
+                if max_bw is None:
+                    qosRule['bwMaxLimitKB'] = int(min_bw) * units.Ki
+            if max_bw:
+                qosRule['bwMaxLimitKB'] = int(max_bw) * units.Ki
+                if min_bw is None:
+                    qosRule['bwMinGoalKB'] = int(max_bw) * units.Ki
+            if latency:
+                # latency could be values like 2, 5, etc or
+                # small values like 0.1, 0.02, etc.
+                # we are converting to float so that 0.1 doesn't become 0
+                latency = float(latency)
+                if latency >= 1:
+                    # by default, latency in millisecs
+                    qosRule['latencyGoal'] = int(latency)
+                else:
+                    # latency < 1 Eg. 0.1, 0.02, etc
+                    # convert latency to microsecs
+                    qosRule['latencyGoaluSecs'] = int(latency * 1000)
+            if priority:
+                qosRule['priority'] = self.qos_priority_level.get(priority.lower())
 
         try:
             self.client.createQoSRules(vvs_name, qosRule)

From a763f3b16d0476e5cbbd60ffdbd83a78d31b9f0a Mon Sep 17 00:00:00 2001
From: jlothe <jyotsna.lothe@hpe.com>
Date: Tue, 10 Feb 2026 15:42:33 +0530
Subject: [PATCH 2/2] ESI-3304 Addressed review comments for removing extra
 spaces

---
 cinder/volume/drivers/hpe/hpe_3par_common.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/cinder/volume/drivers/hpe/hpe_3par_common.py b/cinder/volume/drivers/hpe/hpe_3par_common.py
index 58245a6af7..4901c52787 100644
--- a/cinder/volume/drivers/hpe/hpe_3par_common.py
+++ b/cinder/volume/drivers/hpe/hpe_3par_common.py
@@ -2085,8 +2085,6 @@ def _set_qos_rule(self, qos, vvs_name):
             
             if max_bw:
                 qosRule['bwMaxLimitKB'] = int(max_bw) * units.Ki
-
-
         else:
             # 3PAR/Primera/Alletra 9k: Use traditional QoS parameters
             if min_io: