Improve Use this as parameter

iamrob-nl · iamrob-nl · commit 523afebddcaa · 2022-12-12T12:16:00.000+01:00
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
     "name": "javascriptsnippet",
     "widgetName": "JavaScriptSnippet",
-    "version": "2.1.0",
+    "version": "2.1.1",
     "description": "Insert custom JavaScript to your page.",
     "copyright": "2022 Incentro",
     "author": "Rob Duits",
diff --git a/src/JavaScriptSnippet.jsx b/src/JavaScriptSnippet.jsx
@@ -54,10 +54,9 @@ export function JavaScriptSnippet({ attributeList, jsCode, ...rest }) {
                 }
                 return null;
             });
-
-            JSArray = JSArray.split("this").join(`'${widgetName}_${uid[0]}'`);
-            setJavaScriptString(JSArray);
         }
+        
+        JSArray = JSArray.split("this").join(`'${widgetName}_${uid[0]}'`);
         setJavaScriptString(JSArray);
 
         if (!attributeList.length) {
diff --git a/src/package.xml b/src/package.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <package xmlns="http://www.mendix.com/package/1.0/">
-    <clientModule name="JavaScriptSnippet" version="2.1.0" xmlns="http://www.mendix.com/clientModule/1.0/">
+    <clientModule name="JavaScriptSnippet" version="2.1.1" xmlns="http://www.mendix.com/clientModule/1.0/">
         <widgetFiles>
             <widgetFile path="JavaScriptSnippet.xml" />
         </widgetFiles>

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "javascriptsnippet",`
`3`	`3`	`"widgetName": "JavaScriptSnippet",`
`4`		`- "version": "2.1.0",`
	`4`	`+ "version": "2.1.1",`
`5`	`5`	`"description": "Insert custom JavaScript to your page.",`
`6`	`6`	`"copyright": "2022 Incentro",`
`7`	`7`	`"author": "Rob Duits",`
Original file line number	Diff line number	Diff line change
`@@ -54,10 +54,9 @@ export function JavaScriptSnippet({ attributeList, jsCode, ...rest }) {`
`54`	`54`	`}`
`55`	`55`	`return null;`
`56`	`56`	`});`
`57`		`-`
`58`		- JSArray = JSArray.split("this").join(`'${widgetName}_${uid[0]}'`);
`59`		`- setJavaScriptString(JSArray);`
`60`	`57`	`}`
	`58`	`+`
	`59`	+ JSArray = JSArray.split("this").join(`'${widgetName}_${uid[0]}'`);
`61`	`60`	`setJavaScriptString(JSArray);`
`62`	`61`
`63`	`62`	`if (!attributeList.length) {`