Skip to content

[Feature] Align Android launch command class name with command id #2574

@EmmaYuan1015

Description

@EmmaYuan1015

Background

In src/extension/commands/launchAndroidEmulator.ts, the command class name and command codeName are inconsistent.

  • Class name: LaunchAndroidEmulator
  • codeName: launchAndroidSimulator
  • External command id (from package contribution): reactNative.launchAndroidSimulator

This mismatch adds cognitive overhead and caused a TODO comment in code.

Problem

Although runtime behavior is currently correct (registration uses codeName), the naming inconsistency can confuse maintainers and makes code search/refactoring less clear.

Proposed change

  • Rename class LaunchAndroidEmulator -> LaunchAndroidSimulator
  • Keep codeName = "launchAndroidSimulator" unchanged
  • Remove the TODO comment about naming mismatch

Why this is safe

  • External command id remains unchanged: reactNative.launchAndroidSimulator
  • Command registration logic still uses reactNative.${this.codeName}
  • No behavior change expected, this is a naming consistency cleanup only

Acceptance criteria

  • Class name and codeName are semantically aligned
  • No TODO remains for this mismatch
  • Build/tests pass without functional regressions

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions