-
Notifications
You must be signed in to change notification settings - Fork 281
Open
Labels
Description
Background
In src/extension/commands/launchAndroidEmulator.ts, the command class name and command codeName are inconsistent.
- Class name:
LaunchAndroidEmulator - codeName:
launchAndroidSimulator - External command id (from package contribution):
reactNative.launchAndroidSimulator
This mismatch adds cognitive overhead and caused a TODO comment in code.
Problem
Although runtime behavior is currently correct (registration uses codeName), the naming inconsistency can confuse maintainers and makes code search/refactoring less clear.
Proposed change
- Rename class
LaunchAndroidEmulator->LaunchAndroidSimulator - Keep
codeName = "launchAndroidSimulator"unchanged - Remove the TODO comment about naming mismatch
Why this is safe
- External command id remains unchanged:
reactNative.launchAndroidSimulator - Command registration logic still uses
reactNative.${this.codeName} - No behavior change expected, this is a naming consistency cleanup only
Acceptance criteria
- Class name and
codeNameare semantically aligned - No TODO remains for this mismatch
- Build/tests pass without functional regressions
Reactions are currently unavailable