[Event Request] Codeunit 5887 "Phys. Invt.-Calc. Qty. All".OnRun

[fridrichovsky]

Why do you need this change?

We need skip standard strmenu, bucause we use this codeunit during API actions. It means we have to skip all users interactive parts. This event allow us skip selecetion menu and provide default selection set in setups or provided by API.

New event doesn't skip another events so this not change behavior for another extensions.

Describe the request

    trigger OnRun()
    var
        PhysInvtOrderHeader: Record "Phys. Invt. Order Header";
        PhysInvtOrderLine: Record "Phys. Invt. Order Line";
        Selection: Integer;
        //-----------------------------OnRunOnBeforeSelectSelection:BEGIN
        IsHandled: Boolean;
        //-----------------------------OnRunOnBeforeSelectSelection:END
    begin
        PhysInvtOrderHeader.Copy(Rec);

        //-----------------------------OnRunOnBeforeSelectSelection:BEGIN
        IsHandled := false;
        OnRunOnBeforeSelectSelection(Selection, IsHandled);
        if not IsHandled then
        //-----------------------------OnRunOnBeforeSelectSelection:END
          Selection := StrMenu(SelectionQst, 1);
        if Selection = 0 then
            exit;

        PhysInvtOrderLine.Reset();
        PhysInvtOrderLine.SetRange("Document No.", PhysInvtOrderHeader."No.");
        if PhysInvtOrderLine.Find('-') then
            repeat
                if (Selection = 1) or
                   ((Selection = 2) and not PhysInvtOrderLine."Qty. Exp. Calculated")
                then
                    if not PhysInvtOrderLine.EmptyLine() then begin
                        PhysInvtOrderLine.TestField("Item No.");
                        PhysInvtOrderLine.CalcQtyAndTrackLinesExpected();
                        PhysInvtOrderLine.Modify();
                    end;
            until PhysInvtOrderLine.Next() = 0;

        Rec := PhysInvtOrderHeader;
    end;

    var
        SelectionQst: Label 'All Order Lines,Only Not Calculated Lines';

    //-----------------------------OnRunOnBeforeSelectSelection:BEGIN
    [IntegrationEvent(false, false)]
    local procedure OnRunOnBeforeSelectSelection(var Selection: Integer; var IsHandled: Boolean)
    begin
    end;
    //-----------------------------OnRunOnBeforeSelectSelection:END

Internal work item: AB#625687

[AleksandricMarko]

Hi @fridrichovsky,

Thanks for submitting this extensibility request. To help us process it efficiently, please update the issue to include the required information.

📚 Extensibility Guidelines

Missing Information:

• Alternatives Evaluated: Please explain which existing events or patterns you tried and why they are insufficient for your scenario.

• Justification for IsHandled: The current justification "need to skip StrMenu during API actions" needs more detail. Please provide:

  • Specific technical reason why a standard event is insufficient
  • Concrete business logic explaining why bypassing StrMenu is essential in API context
  • Exact scenario where bypass is necessary
  • Why alternative approaches (redesign, contribution) won't work

  Example of good justification: "We must bypass the StrMenu because our API integration automates physical inventory calculations without user interaction. The StrMenu blocks API execution waiting for user input that will never come in automated scenarios. A standard event firing after the StrMenu selection won't work because the code execution is already blocked waiting for user response. We need to programmatically set the Selection value (1 for all lines, 2 for uncalculated lines) based on API request parameters before the StrMenu is called."

• Performance Considerations: What is the expected execution frequency of this event? How many times will it be called during typical operations (per API call, per batch)? What is the potential performance impact?

• Data Sensitivity Review: Please confirm that no sensitive data is being exposed through this event parameters, or provide rationale if exposure is necessary.

• Multi-Extension Interaction: What are the risks if multiple extensions subscribe to this event with IsHandled? How should conflicts be mitigated?

Please update the issue with the missing details. We'll automatically re-analyze once updated.

[fridrichovsky]

Hello @AleksandricMarko,

Justification for IsHandled: We must bypass the StrMenu because our API integration automates physical inventory calculations without user interaction. The StrMenu blocks API execution waiting for user input that will never come in automated scenarios. A standard event firing after the StrMenu selection won't work because the code execution is already blocked waiting for user response. We need to programmatically set the Selection value (1 for all lines, 2 for uncalculated lines) based on API request parameters before the StrMenu is called.

Performance Considerations: 100/per day

Data Sensitivity Review: There are no record data so what?????

Multi-Extension Interaction can change strmenu.

[AleksandricMarko]

✅ Analysis complete - approved for implementation

---

Implementation:

Add a new IntegrationEvent OnRunOnBeforeSelectSelection with IsHandled parameter in the OnRun trigger of Codeunit 5887 "Phys. Invt.-Calc. Qty. All" before the StrMenu call (around line 37).

Location in OnRun trigger (around line 37):

trigger OnRun()
var
    PhysInvtOrderHeader: Record "Phys. Invt. Order Header";
    PhysInvtOrderLine: Record "Phys. Invt. Order Line";
    Selection: Integer;
    IsHandled: Boolean;
begin
    PhysInvtOrderHeader.Copy(Rec);

    IsHandled := false;
    OnRunOnBeforeSelectSelection(Selection, IsHandled);  // <-- New event
    
    if not IsHandled then begin
        Selection := StrMenu(SelectionQst, 1);
        if Selection = 0 then
            exit;
    end;

    PhysInvtOrderLine.Reset();
    PhysInvtOrderLine.SetRange("Document No.", PhysInvtOrderHeader."No.");
    if PhysInvtOrderLine.Find('-') then
        repeat
            if (Selection = 1) or
               ((Selection = 2) and not PhysInvtOrderLine."Qty. Exp. Calculated")
            then
                if not PhysInvtOrderLine.EmptyLine() then begin
                    PhysInvtOrderLine.TestField("Item No.");
                    PhysInvtOrderLine.CalcQtyAndTrackLinesExpected();
                    PhysInvtOrderLine.Modify();
                end;
        until PhysInvtOrderLine.Next() = 0;

    Rec := PhysInvtOrderHeader;
end;

Event Publisher (add at the end of the codeunit with other events):

[IntegrationEvent(false, false)]
local procedure OnRunOnBeforeSelectSelection(var Selection: Integer; var IsHandled: Boolean)
begin
end;

---

File: PhysInvtCalcQtyAll.Codeunit.al