Skip to content

[bug]: Wait for non-daemon threads to complete work. #101

@lstein

Description

@lstein

Is there an existing issue for this problem?

  • I have searched the existing issues

Install method

Invoke's Launcher

Operating system

Linux

GPU vendor

Nvidia (CUDA)

GPU model

No response

GPU VRAM

No response

Version number

lstein/feature/nicer-shutdown branch

Browser

No response

System Information

No response

What happened

The shutdown code introduced in this branch does an unconditional os._exit(0) upon keyboard interrupt. If some threads are still doing work their work will be interrupted. It would be better to wait for all worker threads to complete their work. This is particularly a concern for the model download and install threads.

What you expected to happen

If a worker thread is active, the system should wait for the threads to complete before exiting. I believe that the download and install managers have a "shutdown" call that should do this.

How to reproduce the problem

No response

Additional context

No response

Discord username

No response

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions