From eab31121e5031962a2af730c628ec46e5f7f2ef7 Mon Sep 17 00:00:00 2001 From: Rafael Sequeira Date: Mon, 2 Mar 2026 20:46:13 +0000 Subject: [PATCH] fix: propagate cargo metada errors instead of silent --no-deps fallback resolve_ws() silently retries with --no-deps when cargo metadata fails. This hides errors and causes set-version to skip lockfile updates without any indication of failure. Remove the or_else fallback so errors propagate to the caller. Fixes #891 --- src/bin/set-version/set_version.rs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/bin/set-version/set_version.rs b/src/bin/set-version/set_version.rs index a235b353b2..bcf10a5a16 100644 --- a/src/bin/set-version/set_version.rs +++ b/src/bin/set-version/set_version.rs @@ -348,10 +348,7 @@ fn resolve_ws( } cmd.other_options(other); - let ws = cmd.exec().or_else(|_| { - cmd.no_deps(); - cmd.exec() - })?; + let ws = cmd.exec()?; Ok(ws) }