[Enhancement!] Default AV Sync Mode -> 'Resample' #1117
Description
I wouldn't normally drop this default settings change as an enhancement request, but please consider it below given how egregious it can be and how little documentation is available. After digging into the code a bit, the settings are misleading to the end user and it appears to recommend a non-default option.
To Reproduce
I have an Interstellar DVD that I copied and am playing more or less raw / high bitrate on a 5.1 system. Other titles show this effect, but this one is particularly rough.
At ~1:29 to 1:48 in that title there is a scene where a spacecraft is losing control. The audio (and video!) appears jumpy and laggy at some of the transitions. I thought it was a hardware error or stutter. Any google-fu tends to blame the user.
If you go to Jellyfin Settings -> Client Settings -> AV Sync Mode and change it to Resample the issue goes away.
Everything I tried works better than the Jellyfin defaults. The actual DVD on Win Media Player and the rip on Media Player and VLC all play without issue. Streaming from Jellyfin web client doesn't have this issue (but transcodes my audio by default, so not a fair comparison). I even tried on Android mobile, Android client, and Android TV clients - they are all transcoding audio on the server (so not fair comparison) but again do NOT exhibit the audio/visual stutter that this client does.
Documentation Errors and Suggestions
https://github.com/jellyfin/jellyfin-desktop/blob/master/resources/settings/settings_description.json#L365
If you use this option, you usually want to set it to display-resample to enable a timing mode that tries to not skip or repeat frames when for example playing 24fps video on a 24Hz screen.
The user-facing documentation seems to state that you want to change to Resample, which works great. That wording is confusing because it calls it Display-Resample which is the internal/code name, not the user-facing name, and it states "if you use this option", but it's already in use, just with a different default.
I don't quite understand what it's trying to say with the 24 Hz screen either. My PC has a high refresh monitor, but the other two modes (as they state they do) seem to drop or repeat frames and creates a very jarring effect that makes it appear as if the PC is freezing or stuttering.
I don't think this is a personal preference thing; from reading the choices it appears that the default isn't the best choice. Unfortunately, the effect of the default and resulting high-ranked internet searches led me (and I assume other users) to believe it's a driver or other hardware deficiency.