CircularBuffer has no tests

[misterspeedy]

CircularBuffer has no tests. Also it would be nice to have a comment which says how this structure differs from RingBuffer, which also exists in the codebase.

[panesofglass]

Tests were never formalized as such. They were also left in F#x in the samples: CircularBuffer.fsx. As to the nearly duplicate RingBuffer, @jackfoxy and I were supposed to sync up on that. We'll take a look next week.

TODO:

• Move/add tests for CircularBuffer from F#x
• Merge CircularBuffer and RingBuffer or otherwise indicate their specific uses
• Bring this back into F#x and replace the other RingBuffer in the F#x Observable module

[jackfoxy]

marking as a bug for now, as all main collections data structures should have tests

[jackfoxy]

added some tests, but ran into bug #123

[jackfoxy]

Resolved #123 and found new bug, #125

[github-actions]

🤖 This is an automated response from Repo Assist.

Good news on this front! Tests for CircularBuffer have been in the repository for some time now — see tests/FSharpx.Collections.Tests/CircularBufferTests.fs.

The test file covers single-element and array Enqueue, Dequeue, overflow detection, and wrapping behaviour. Three tests are currently pending (ptest) because of the Enqueue(array) bug tracked in #125 — but PR #233 fixes that bug and activates those tests.

Once #233 is merged, CircularBuffer will have full, passing test coverage. This issue could then be closed.

As a side note: the original TODO about RingBuffer (merging or documenting the difference) is still open — that might be worth a separate issue if it's still relevant.

Generated by Repo Assist · ◷

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@346204513ecfa08b81566450d7d599556807389f