From 8e5cbe973cc9f45c05cd6201255ca69500b04215 Mon Sep 17 00:00:00 2001 From: Brad Keryan Date: Tue, 17 Mar 2026 09:30:44 -0500 Subject: [PATCH 1/2] github: Fix outdated aspects of Comment-on-PR.yml and Notify-Convention-Change.yml (#291) * github: Remove with: GITHUB_TOKEN from thollander/actions-comment-pull-request * github: Pin actions/checkout * github: Specify required permissions for jobs that call thollander/actions-comment-pull-request * github: Add a name for Comment-on-PR.yml * github: Remove actions/checkout from comment workflows --- .github/workflows/Comment-on-PR.yml | 8 ++++---- .github/workflows/Notify-Convention-Change.yml | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/Comment-on-PR.yml b/.github/workflows/Comment-on-PR.yml index 933d65f7..d1a52e55 100644 --- a/.github/workflows/Comment-on-PR.yml +++ b/.github/workflows/Comment-on-PR.yml @@ -1,3 +1,5 @@ +name: Comment on PR + on: pull_request_target: paths-ignore: @@ -10,13 +12,11 @@ jobs: comment_on_pr: runs-on: ubuntu-latest name: PR comment + permissions: + pull-requests: write steps: - - name: Checkout - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - - name: Comment on PR uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1 with: message: | Thank you for contributing! :wave: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/Notify-Convention-Change.yml b/.github/workflows/Notify-Convention-Change.yml index fec826b4..9a5005cf 100644 --- a/.github/workflows/Notify-Convention-Change.yml +++ b/.github/workflows/Notify-Convention-Change.yml @@ -19,8 +19,9 @@ jobs: notify: runs-on: ubuntu-latest needs: org-check + permissions: + pull-requests: write steps: - - uses: actions/checkout@main - name: Comment on PR uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1 with: @@ -43,4 +44,3 @@ jobs: @Adithyak1998 @innagarc @ShibaniRout - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From a59f06ccd88a56c3a311f0826a1aa7f146013586 Mon Sep 17 00:00:00 2001 From: Brad Keryan Date: Tue, 17 Mar 2026 00:24:34 -0500 Subject: [PATCH 2/2] Update README.md --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index c70844ac..7668897e 100644 --- a/README.md +++ b/README.md @@ -9,6 +9,8 @@ Welcome to NI's internal and external Python conventions and enforcement tooling. +asdf + ## Written Conventions Our written conventions can be found at https://ni.github.io/python-styleguide/.