From fd4cc27ef2c0b260073109b8ad1863b7961e2464 Mon Sep 17 00:00:00 2001 From: Moritz Hoffmann Date: Tue, 24 Feb 2026 09:37:31 +0100 Subject: [PATCH 1/2] Update github workflows Updates the github workflows: * Run deploy and release-plz in their own concurrency group to avoid race conditions. * Run deploy on recent Ubuntu, update mdbook. * Only let the check-against-Timely-master workflow create issues in the main repository. This avoids tagging people on random forks. * Run clippy, but do not fail on its warnings. * Re-enable Windows tests. Signed-off-by: Moritz Hoffmann --- .github/workflows/deploy.yml | 7 +++++-- .github/workflows/release-plz.yml | 3 +++ .github/workflows/test-timely-master.yml | 2 +- .github/workflows/test.yml | 16 +++++++++++++++- 4 files changed, 24 insertions(+), 4 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index f22353ed2..d5630c90b 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -5,12 +5,15 @@ on: branches: - master +concurrency: + group: deploy + jobs: deploy: - runs-on: ubuntu-24.04 + runs-on: ubuntu-latest steps: - uses: actions/checkout@v6 - - run: cargo install mdbook --version 0.4.44 + - run: cargo install mdbook --version 0.5.2 - name: Patch sample Cargo.toml versions run: | export DIFFERENTIAL_VERSION=$(cargo metadata --format-version 1 | jq -r '.packages[] | select(.name == "differential-dataflow") | .version') diff --git a/.github/workflows/release-plz.yml b/.github/workflows/release-plz.yml index d81fcd7d8..0a43f8347 100644 --- a/.github/workflows/release-plz.yml +++ b/.github/workflows/release-plz.yml @@ -9,6 +9,9 @@ on: branches: - master +concurrency: + group: release-plz + jobs: release-plz: name: Release-plz diff --git a/.github/workflows/test-timely-master.yml b/.github/workflows/test-timely-master.yml index bd6928918..3745bfcdf 100644 --- a/.github/workflows/test-timely-master.yml +++ b/.github/workflows/test-timely-master.yml @@ -36,7 +36,7 @@ jobs: notify: name: Notify failed build - if: failure() && github.event.pull_request == null + if: failure() && github.repository == 'TimelyDataflow/differential-dataflow' needs: [tests] permissions: contents: read diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index e557a1f51..260e0552f 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -12,7 +12,7 @@ jobs: os: - ubuntu - macos - # - windows + - windows toolchain: - stable - 1.86 @@ -27,3 +27,17 @@ jobs: run: cargo test --workspace --all-targets - name: Cargo doc test run: cargo test --doc + + # Check for clippy warnings + clippy: + name: Cargo clippy + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v6 + - uses: actions-rust-lang/setup-rust-toolchain@v1 + with: + components: clippy + - name: Cargo clippy + run: cargo clippy --workspace --all-targets + env: + RUSTFLAGS: "" # Don't make test fail on clippy From 3571eb113fe5b7fd41e70fbfaa120eb64e162203 Mon Sep 17 00:00:00 2001 From: Moritz Hoffmann Date: Tue, 24 Feb 2026 09:43:53 +0100 Subject: [PATCH 2/2] Update clippy lints Signed-off-by: Moritz Hoffmann --- Cargo.toml | 63 ++++++++++++++++++++++++++++++++ advent_of_code_2017/Cargo.toml | 3 ++ differential-dataflow/Cargo.toml | 3 ++ dogsdogsdogs/Cargo.toml | 3 ++ doop/Cargo.toml | 3 ++ experiments/Cargo.toml | 3 ++ interactive/Cargo.toml | 3 ++ mdbook/Cargo.toml | 3 ++ server/Cargo.toml | 3 ++ 9 files changed, 87 insertions(+) diff --git a/Cargo.toml b/Cargo.toml index 121a1c550..98dab630f 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -26,6 +26,69 @@ columnar = { version = "0.11", default-features = false } timely = { git = "https://github.com/TimelyDataflow/timely-dataflow" } #timely = { path = "../timely-dataflow/timely/", default-features = false } +[workspace.lints.clippy] +type_complexity = "allow" +option_map_unit_fn = "allow" +wrong_self_convention = "allow" +should_implement_trait = "allow" +module_inception = "allow" + +#as_conversions = "warn" +bool_comparison = "warn" +borrow_interior_mutable_const = "warn" +borrowed_box = "warn" +builtin_type_shadow = "warn" +clone_on_ref_ptr = "warn" +crosspointer_transmute = "warn" +dbg_macro = "warn" +deref_addrof = "warn" +disallowed_macros = "warn" +disallowed_methods = "warn" +disallowed_types = "warn" +double_must_use = "warn" +double_parens = "warn" +duplicate_underscore_argument = "warn" +excessive_precision = "warn" +extra_unused_lifetimes = "warn" +from_over_into = "warn" +match_overlapping_arm = "warn" +must_use_unit = "warn" +mut_mutex_lock = "warn" +needless_borrow = "warn" +needless_pass_by_ref_mut = "warn" +needless_question_mark = "warn" +needless_return = "warn" +no_effect = "warn" +panicking_overflow_checks = "warn" +partialeq_ne_impl = "warn" +print_literal = "warn" +redundant_closure = "warn" +redundant_closure_call = "warn" +redundant_field_names = "warn" +redundant_pattern = "warn" +redundant_slicing = "warn" +redundant_static_lifetimes = "warn" +same_item_push = "warn" +shadow_unrelated = "warn" +single_component_path_imports = "warn" +suspicious_assignment_formatting = "warn" +suspicious_else_formatting = "warn" +suspicious_unary_op_formatting = "warn" +todo = "warn" +transmutes_expressible_as_ptr_casts = "warn" +unnecessary_cast = "warn" +unnecessary_lazy_evaluations = "warn" +unnecessary_mut_passed = "warn" +unnecessary_unwrap = "warn" +unused_async = "warn" +useless_asref = "warn" +useless_conversion = "warn" +useless_format = "warn" +wildcard_in_or_patterns = "warn" +write_literal = "warn" +zero_divided_by_zero = "warn" +zero_prefixed_literal = "warn" + [profile.release] opt-level = 3 debug = true diff --git a/advent_of_code_2017/Cargo.toml b/advent_of_code_2017/Cargo.toml index ab9aaad3a..31baf574e 100644 --- a/advent_of_code_2017/Cargo.toml +++ b/advent_of_code_2017/Cargo.toml @@ -4,6 +4,9 @@ version = "0.1.0" authors = ["Frank McSherry "] publish = false +[lints] +workspace = true + [dependencies] differential-dataflow = { workspace = true } timely = { git = "https://github.com/frankmcsherry/timely-dataflow" } diff --git a/differential-dataflow/Cargo.toml b/differential-dataflow/Cargo.toml index a421d96ee..586b3948f 100644 --- a/differential-dataflow/Cargo.toml +++ b/differential-dataflow/Cargo.toml @@ -15,6 +15,9 @@ license = "MIT" readme = "../README.md" edition.workspace = true +[lints] +workspace = true + [dev-dependencies] rand="0.4" itertools="^0.13" diff --git a/dogsdogsdogs/Cargo.toml b/dogsdogsdogs/Cargo.toml index fa40e9adf..196b51f35 100644 --- a/dogsdogsdogs/Cargo.toml +++ b/dogsdogsdogs/Cargo.toml @@ -10,6 +10,9 @@ documentation = "https://docs.rs/differential-dogs3" homepage = "https://github.com/TimelyDataflow/differential-dataflow" repository = "https://github.com/TimelyDataflow/differential-dataflow.git" +[lints] +workspace = true + [dependencies] timely = { workspace = true } differential-dataflow = { workspace = true } diff --git a/doop/Cargo.toml b/doop/Cargo.toml index e195b7014..936261367 100644 --- a/doop/Cargo.toml +++ b/doop/Cargo.toml @@ -5,6 +5,9 @@ authors = ["Frank McSherry "] edition.workspace = true publish = false +[lints] +workspace = true + [dependencies] timely = {workspace = true} differential-dataflow = { workspace = true } diff --git a/experiments/Cargo.toml b/experiments/Cargo.toml index 1f1811dc8..7767a0dd3 100644 --- a/experiments/Cargo.toml +++ b/experiments/Cargo.toml @@ -5,6 +5,9 @@ authors = ["Frank McSherry "] edition.workspace = true publish = false +[lints] +workspace = true + [dependencies] core_affinity = "0.5.9" rand="0.3.13" diff --git a/interactive/Cargo.toml b/interactive/Cargo.toml index 8b6a3bd5a..7515ed97a 100644 --- a/interactive/Cargo.toml +++ b/interactive/Cargo.toml @@ -5,6 +5,9 @@ authors = ["Frank McSherry "] edition.workspace = true publish = false +[lints] +workspace = true + [dependencies] bincode = "1" serde = { version = "1", features = ["derive"]} diff --git a/mdbook/Cargo.toml b/mdbook/Cargo.toml index d04f41fc6..5cea3e71c 100644 --- a/mdbook/Cargo.toml +++ b/mdbook/Cargo.toml @@ -4,6 +4,9 @@ version = "0.0.0" edition.workspace = true publish = false +[lints] +workspace = true + [dependencies] differential-dataflow = { path = "../differential-dataflow" } timely.workspace = true diff --git a/server/Cargo.toml b/server/Cargo.toml index c9e9ade3e..dda908dd0 100644 --- a/server/Cargo.toml +++ b/server/Cargo.toml @@ -5,6 +5,9 @@ authors = ["Frank McSherry "] edition.workspace = true publish = false +[lints] +workspace = true + [dependencies] libloading = "0.8" differential-dataflow = { workspace = true }