From ebdc1467ba5319508a7e3f34707a1676d9d3ff47 Mon Sep 17 00:00:00 2001 From: Mattias Buelens Date: Tue, 3 Mar 2026 14:13:46 +0100 Subject: [PATCH 1/6] Refactor --- ui/src/main/java/com/theoplayer/android/ui/Player.kt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/src/main/java/com/theoplayer/android/ui/Player.kt b/ui/src/main/java/com/theoplayer/android/ui/Player.kt index ca4986d..82cdb3d 100644 --- a/ui/src/main/java/com/theoplayer/android/ui/Player.kt +++ b/ui/src/main/java/com/theoplayer/android/ui/Player.kt @@ -511,7 +511,9 @@ internal class PlayerImpl(override val theoplayerView: THEOplayerView?) : Player private set override val pictureInPictureSupported: Boolean by lazy { - (theoplayerView?.context as? Activity)?.supportsPictureInPictureMode() ?: false + val theoplayerView = theoplayerView ?: return@lazy false + val activity = theoplayerView.context as? Activity ?: return@lazy false + activity.supportsPictureInPictureMode() } override fun enterPictureInPicture(pipType: PiPType) { From 425a4533e61c711738dff4b30e75b7f1fe68aa79 Mon Sep 17 00:00:00 2001 From: Mattias Buelens Date: Tue, 3 Mar 2026 14:14:49 +0100 Subject: [PATCH 2/6] Check if `PiPManager` is available --- ui/src/main/java/com/theoplayer/android/ui/Player.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/src/main/java/com/theoplayer/android/ui/Player.kt b/ui/src/main/java/com/theoplayer/android/ui/Player.kt index 82cdb3d..d65f518 100644 --- a/ui/src/main/java/com/theoplayer/android/ui/Player.kt +++ b/ui/src/main/java/com/theoplayer/android/ui/Player.kt @@ -513,7 +513,7 @@ internal class PlayerImpl(override val theoplayerView: THEOplayerView?) : Player override val pictureInPictureSupported: Boolean by lazy { val theoplayerView = theoplayerView ?: return@lazy false val activity = theoplayerView.context as? Activity ?: return@lazy false - activity.supportsPictureInPictureMode() + theoplayerView.piPManager != null && activity.supportsPictureInPictureMode() } override fun enterPictureInPicture(pipType: PiPType) { From cf7600752592fecad5722a599d078984f8972dc1 Mon Sep 17 00:00:00 2001 From: Mattias Buelens Date: Tue, 3 Mar 2026 14:23:21 +0100 Subject: [PATCH 3/6] Update changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7a91ae0..b92c351 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,10 @@ > - 🏠 Internal > - 💅 Polish +## Unreleased + +* 🐛 Fixed `PictureInPictureButton` to only be shown when the backing `THEOplayerView` has a valid `PiPConfiguration`. ([#81](https://github.com/THEOplayer/android-ui/pull/81)) + ## v1.13.1 (2026-01-05) * 🐛 Changed THEOplayer to be an `api` dependency in Gradle. ([#76](https://github.com/THEOplayer/android-ui/pull/76)) From 390f7e1b07aa87a607ec0e8c179e85e5daaccba8 Mon Sep 17 00:00:00 2001 From: Mattias Buelens Date: Tue, 3 Mar 2026 14:26:15 +0100 Subject: [PATCH 4/6] Update demo to THEOplayer 10.11.0 --- .../main/java/com/theoplayer/android/ui/demo/MainActivity.kt | 2 +- gradle/libs.versions.toml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/theoplayer/android/ui/demo/MainActivity.kt b/app/src/main/java/com/theoplayer/android/ui/demo/MainActivity.kt index ed29d6b..14e3ad5 100644 --- a/app/src/main/java/com/theoplayer/android/ui/demo/MainActivity.kt +++ b/app/src/main/java/com/theoplayer/android/ui/demo/MainActivity.kt @@ -75,7 +75,7 @@ fun MainContent() { val context = LocalContext.current val theoplayerView = remember(context) { val config = THEOplayerConfig.Builder().apply { - pipConfiguration(PipConfiguration.Builder().build()) + pip(PipConfiguration.Builder().build()) }.build() THEOplayerView(context, config).apply { // Add ads integration through Google IMA diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 70571fa..0b273d0 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -16,7 +16,7 @@ androidx-junit = "1.3.0" androidx-espresso = "3.7.0" androidx-mediarouter = "1.8.1" dokka = "2.0.0" -theoplayer = { prefer="10.0.0", strictly = "[5.0, 11.0)" } +theoplayer = { prefer="10.11.0", strictly = "[5.0, 11.0)" } [libraries] androidx-ktx = { group = "androidx.core", name = "core-ktx", version.ref = "ktx" } From ed68b8212a2fae1fe7e73373918f224354c67bb1 Mon Sep 17 00:00:00 2001 From: Mattias Buelens Date: Tue, 3 Mar 2026 14:38:03 +0100 Subject: [PATCH 5/6] Fix comments --- scripts/github_changelog.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/github_changelog.js b/scripts/github_changelog.js index fb2b2e5..e94dbb7 100755 --- a/scripts/github_changelog.js +++ b/scripts/github_changelog.js @@ -11,13 +11,12 @@ if (!version) { const changelogPath = path.resolve(__dirname, "../CHANGELOG.md"); const changelog = fs.readFileSync(changelogPath, "utf-8"); const headingStart = "## "; -// Find block with current version const block = changelog .split(headingStart) .find((block) => block.startsWith(`v${version}`)) .trim(); let lines = block.split("\n"); -// Remove version +// Remove version heading lines.splice(0, 1); console.log(lines.join("\n").trim()); From ae66d8b81f7918c2ebbea119ab608ce48eb5e3eb Mon Sep 17 00:00:00 2001 From: "theoplayer-bot[bot]" <873105+theoplayer-bot[bot]@users.noreply.github.com> Date: Tue, 3 Mar 2026 13:38:50 +0000 Subject: [PATCH 6/6] 1.13.2 --- CHANGELOG.md | 2 +- gradle.properties | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b92c351..e1a3293 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,7 @@ > - 🏠 Internal > - 💅 Polish -## Unreleased +## v1.13.2 (2026-03-03) * 🐛 Fixed `PictureInPictureButton` to only be shown when the backing `THEOplayerView` has a valid `PiPConfiguration`. ([#81](https://github.com/THEOplayer/android-ui/pull/81)) diff --git a/gradle.properties b/gradle.properties index 7ce742d..c396b12 100644 --- a/gradle.properties +++ b/gradle.properties @@ -27,4 +27,4 @@ org.gradle.configuration-cache=true org.jetbrains.dokka.experimental.gradle.pluginMode=V2Enabled org.jetbrains.dokka.experimental.gradle.pluginMode.noWarn=true # The version of the THEOplayer Open Video UI for Android. -version=1.13.1 +version=1.13.2