From d467fb8d8979aa5612f8437b00df809fc96036f9 Mon Sep 17 00:00:00 2001
From: David Hewitt <mail@davidhewitt.dev>
Date: Fri, 13 Mar 2026 13:17:33 +0000
Subject: [PATCH] add example of `#[pyclass]` usage

---
 microbiorust-py/Cargo.toml |  7 ++---
 microbiorust-py/src/lib.rs | 61 +++++++++++++++++++++++++++++++-------
 2 files changed, 54 insertions(+), 14 deletions(-)

diff --git a/microbiorust-py/Cargo.toml b/microbiorust-py/Cargo.toml
index 701703d..286d97a 100644
--- a/microbiorust-py/Cargo.toml
+++ b/microbiorust-py/Cargo.toml
@@ -20,7 +20,7 @@ name = "microbiorust"
 crate-type = ["cdylib"]
 
 [dependencies.pyo3]
-version = "0.25.0" 
+version = "0.25.0"
 features = ["extension-module", "abi3-py310"]
 
 [features]
@@ -28,8 +28,7 @@ default = ["extension-module"]
 extension-module = ["pyo3/extension-module"]
 
 [dependencies]
-microBioRust = "0.1.3"
-microBioRust-seqmetrics = "0.1.3"
+microBioRust = { version = "0.1.3", path = "../microBioRust" }
+microBioRust-seqmetrics = { version = "0.1.3", path = "../seqmetrics" }
 pythonize = "0.25"
 tokio = { version = "1.49.0", features = ["full"] }
-
diff --git a/microbiorust-py/src/lib.rs b/microbiorust-py/src/lib.rs
index 423f252..1ce886a 100644
--- a/microbiorust-py/src/lib.rs
+++ b/microbiorust-py/src/lib.rs
@@ -39,6 +39,8 @@
 #[macro_use]
 mod macros;
 
+use pyo3::exceptions::PyKeyError;
+use pyo3::types::PyList;
 use pyo3::{
    prelude::*,
    types::PyModule,
@@ -63,18 +65,57 @@ use microBioRust_seqmetrics::metrics::amino_counts as rust_amino_counts;
 use microBioRust_seqmetrics::metrics::amino_percentage as rust_amino_percentage;
 
 
-#[pyfunction]
-pub fn gbk_to_faa(filename: &str) -> PyResult<Vec<String>> {  
-    let records = genbank!(&filename);
-    let mut result = Vec::new();
-    for record in records {
-        for (k, _v) in &record.cds.attributes {
-            if let Some(seq) = record.seq_features.get_sequence_faa(k) {
-                result.push(format!(">{}|{}\n{}", &record.id, &k, seq));
-            }
+#[pyclass]
+struct Faa {
+    records: HashMap<String, Record>,
+}
+
+/// A wrapper around the Record type to expose it to Python
+#[pyclass(name = "Record")]
+struct PyRecord(Record);
+
+#[pymethods]
+impl Faa {
+    fn __repr__(&self) -> String {
+        format!("Faa({} records)", self.records.len())
+    }
+
+    fn __getitem__(&self, record_id: &str) -> PyResult<PyRecord> {
+        match self.records.get(record_id) {
+            Some(record) => Ok(PyRecord(record.clone())),
+            None => Err(PyKeyError::new_err(record_id.to_string())),
         }
     }
-    Ok(result)
+
+    fn keys<'py>(&self, py: Python<'py>) -> PyResult<Bound<'py, PyList>> {
+        PyList::new(py, self.records.keys())
+    }
+}
+
+#[pymethods]
+impl PyRecord {
+    fn __repr__(&self) -> String {
+        format!("Record(id: {}, sequence length: {})", self.0.id, self.0.sequence.len())
+    }
+    
+    fn id(&self) -> &str {
+        &self.0.id
+    }
+
+    fn get_sequence(&self) -> String {
+        self.0.sequence.clone()
+    }
+
+    fn get_attributes(&self) -> HashMap<String, String> {
+        self.0.cds.attributes.iter().map(|(k, v)| (k.clone(), format!("{v:?}"))).collect()
+    }
+}
+
+#[pyfunction]
+pub fn gbk_to_faa(filename: &str) -> PyResult<Faa> {
+    let records = genbank!(&filename);
+    let records = records.into_iter().map(|r| (r.id.clone(), r)).collect();
+    Ok(Faa { records })
 }
 
 #[pyfunction]