You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After looking at all .proto files of DFHack, which are written in proto2 syntax, I noticed that the RPC functions only appear as comments :
// RPC GetSideMenu : EmptyMessage -> SidebarState
That's nice, but for automation purposes I'd like something more reliable. Instead of comments, I would like actual service blocks, as allowed by the proto2 syntax:
service MyService { rpc GetSideMenu (EmptyMessage) returns (SidebarState); }
May I create a Pull Request with that change? any objections ? Any blocker? It's literally just a conversion task, there's no caveat.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
After looking at all
.protofiles of DFHack, which are written inproto2syntax, I noticed that the RPC functions only appear as comments :// RPC GetSideMenu : EmptyMessage -> SidebarStateThat's nice, but for automation purposes I'd like something more reliable. Instead of comments, I would like actual
serviceblocks, as allowed by theproto2syntax:service MyService { rpc GetSideMenu (EmptyMessage) returns (SidebarState); }May I create a Pull Request with that change? any objections ? Any blocker? It's literally just a conversion task, there's no caveat.
Beta Was this translation helpful? Give feedback.
All reactions